Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate inState prop of view components #33

Closed
UberMouse opened this issue Nov 15, 2022 · 1 comment
Closed

Deprecate inState prop of view components #33

UberMouse opened this issue Nov 15, 2022 · 1 comment

Comments

@UberMouse
Copy link
Collaborator

This prop is the only prop passed to views that is tricky to type correctly when using the view directly (ex in Storybook stories or tests) as it depends on typegen information from the machine. It's also better practice to use the same inState function that is in the selectors to instead add something to the selectors to determine your conditional with in the view instead of using inState directly in the view.

In light of that, inState should be deprecated and when #14 is done the new system should not provide inState to the view.
UberMouse added a commit that referenced this issue Nov 15, 2022
@UberMouse
chore(view): deprecate inState
4c8ad20 
Closes Deprecate `inState` prop of view components #33
@UberMouse
Copy link
Collaborator Author

Closed by 4c8ad20

github-actions bot pushed a commit that referenced this issue Nov 29, 2022
@semantic-release-bot
release(version): Release 4.1.0-beta.1 [skip ci]
0b8fb22 
# [4.1.0-beta.1](v4.0.1...v4.1.0-beta.1) (2022-11-29)

### chore

* **view:** deprecate inState ([4c8ad20](4c8ad20)), closes [#33](#33)

### feat

* **builders:** builders 2.0 ([f285acd](f285acd)), closes [#14](#14)
github-actions bot pushed a commit that referenced this issue Dec 19, 2022
@semantic-release-bot
release(version): Release 4.1.0 [skip ci]
ab53445 
# [4.1.0](v4.0.1...v4.1.0) (2022-12-19)

### chore

* **deps:** update api-extractor ([3c9941c](3c9941c))
* **view:** deprecate inState ([4c8ad20](4c8ad20)), closes [#33](#33)

### feat

* **builders:** builders 2.0 ([f285acd](f285acd)), closes [#14](#14)
* **routing:** add TestRoutingContext ([1534fd5](1534fd5))
* **routing:** history argument is now a function ([5297c8b](5297c8b))
* **routing:** useIsRouteActive ([9b7b689](9b7b689))
* **routing:** useRouteArgsIfActive ([f28dc6f](f28dc6f))

### fix

* **builders:** v2 builder view triggering rule of hooks ([cfd7b5a](cfd7b5a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UberMouse