Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: add hadoop yarn chart #21

Merged
merged 2 commits into from
Aug 18, 2023
Merged

chart: add hadoop yarn chart #21

merged 2 commits into from
Aug 18, 2023

Conversation

sjtufl
Copy link
Collaborator

@sjtufl sjtufl commented Aug 11, 2023

Ⅰ. Describe what this PR does

Add hadoop yarn chart, which will help folks deploy a yarn cluster at ease. Hadoop yarn 3.3.2 is the adopted version currently.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107
Copy link
Collaborator

zwzhang0107 commented Aug 14, 2023

  1. some services are not necessary (yarn-api?)
  2. slb should be an option in value
  3. maybe we should use kubectl to get all rm pods in bootstrap.sh if HA is enabled.
  4. git commit with -s for sign-off

@sjtufl
Copy link
Collaborator Author

sjtufl commented Aug 15, 2023

  1. some services are not necessary (yarn-api?)
  2. slb should be an option in value
  3. maybe we should use kubectl to get all rm pods in bootstrap.sh if HA is enabled.
  4. git commit with -s for sign-off
  1. duplicated service has been removed;
  2. added exposeViaLB option for rm & nm;
  3. yeah it's feasible, will work on this later. BTW, should we take the deployment of zookeeper (required if HA is enabled) into consideration?
  4. done.

@zwzhang0107
Copy link
Collaborator

  1. Dockerfile
  2. Deployment
  3. headless svc delete

Signed-off-by: fang <jerryfang555@qq.com>
Signed-off-by: fang <jerryfang555@qq.com>
@sjtufl
Copy link
Collaborator Author

sjtufl commented Aug 16, 2023

  1. Dockerfile
  2. Deployment
  3. headless svc delete

@zwzhang0107 Done. PTAL.

@zwzhang0107
Copy link
Collaborator

nice job!

@zwzhang0107 zwzhang0107 changed the title feat: add hadoop yarn chart chart: add hadoop yarn chart Aug 18, 2023
@zwzhang0107
Copy link
Collaborator

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ec8b7ae into main Aug 18, 2023
10 checks passed
@zwzhang0107 zwzhang0107 deleted the add-yarn-chart branch November 17, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants