koordlet: reduce unnecessary call of Err() for better performance (#2071

) Signed-off-by: yangfeiyu <yangfeiyu20102011@163.com>
koordinator-sh · May 30, 2024 · 8e41abc · 8e41abc
1 parent a685498
commit 8e41abc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/koordlet/metriccache/metric_result.go b/pkg/koordlet/metriccache/metric_result.go
@@ -105,8 +105,8 @@ func (r *aggregateResult) AddSeries(series promstorage.Series) error {
 	}
 	it := series.Iterator()
 	for it.Next() {
-		if it.Err() != nil {
-			return it.Err()
+		if err := it.Err(); err != nil {
+			return err
 		}
 		t, v := it.At()
 		r.points = append(r.points, &Point{