Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] CI should fail if diff coverage is below 70% #124

Closed
jasonliu747 opened this issue May 6, 2022 · 3 comments · Fixed by #208
Closed

[proposal] CI should fail if diff coverage is below 70% #124

jasonliu747 opened this issue May 6, 2022 · 3 comments · Fixed by #208
Assignees
Labels
kind/proposal Create a report to help us improve
Milestone

Comments

@jasonliu747
Copy link
Member

Why is this needed:
Diff coverage is the percentage of new or modified lines that are covered by tests. This provides a clear and achievable standard for code review: If you touch a line of code, that line should be covered.

Code coverage is every developer's responsibility!

So, I think CI should fail if diff coverage is below 70% or something else.

Is there a suggested solution, if so, please add it:
Codecov might support this. Need to do some research.

@jasonliu747 jasonliu747 added the kind/proposal Create a report to help us improve label May 6, 2022
@jasonliu747
Copy link
Member Author

jasonliu747 commented May 6, 2022

Expect something like this:
image

@jasonliu747 jasonliu747 added this to the v0.4 milestone May 7, 2022
@hormes
Copy link
Member

hormes commented May 7, 2022

+10086

@jasonliu747
Copy link
Member Author

@saintube #131 didn't work, please take a look when you're free. Thanks.

@jasonliu747 jasonliu747 modified the milestones: v0.4, someday May 30, 2022
@jasonliu747 jasonliu747 linked a pull request Jun 5, 2022 that will close this issue
@jasonliu747 jasonliu747 modified the milestones: someday, v0.5 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Create a report to help us improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants