Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov.yaml #208

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

saintube
Copy link
Member

@saintube saintube commented Jun 2, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

  1. update codecov.yaml, change PR blocking for project-level coverage into -2% (before: -5%)
  2. add unit tests for meminfo.go

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

test CI blocking for coverage

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #208 (45d0acc) into main (49850ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         100      100           
  Lines        9222     9222           
=======================================
  Hits         5397     5397           
  Misses       3374     3374           
  Partials      451      451           
Flag Coverage Δ
unittests 58.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49850ce...45d0acc. Read the comment docs.

@saintube saintube force-pushed the trigger-ut branch 4 times, most recently from 52b2dff to 01a21f3 Compare June 2, 2022 11:06
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube changed the title chore: add ut for meminfo.go chore: update codecov.yaml Jun 5, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 5, 2022
@jasonliu747 jasonliu747 linked an issue Jun 5, 2022 that may be closed by this pull request
@hormes
Copy link
Member

hormes commented Jun 6, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 282342c into koordinator-sh:main Jun 6, 2022
cheimu pushed a commit to cheimu/koordinator that referenced this pull request Jun 7, 2022
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: yimo <yimo@xiaohongshu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] CI should fail if diff coverage is below 70%
4 participants