Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] 关于batch资源计算方式的疑问 #1729

Closed
j4ckstraw opened this issue Oct 30, 2023 · 3 comments
Closed

[question] 关于batch资源计算方式的疑问 #1729

j4ckstraw opened this issue Oct 30, 2023 · 3 comments
Labels
area/koord-manager kind/bug Create a report to help us improve kind/question Support request or question relating to Koordinator lifecycle/stale

Comments

@j4ckstraw
Copy link
Contributor

What happened:

  1. 为什么要引入一种按照request来计算batch资源的策略?
  2. 对于koord-mid priority是否应该使用mid-cpu/mid-memory?
  3. 接问题2,如果koord-mid priority使用mid-cpu/mid-memory资源,在按照request policy计算batch资源时,扣减High Priority Pod Request,这里podRequest计算有问题。
    https://github.com/koordinator-sh/koordinator/blob/f43d4fd947017b7b7fd4d6e453b171bf7387457f/pkg/slo-
    controller/noderesource/plugins/batchresource/plugin.go#L187C5-L187C5

What you expected to happen:

Environment:

  • Koordinator version: - v0.6.2
  • Kubernetes version (use kubectl version): v1.22.5
  • docker/containerd version: containerd 1.5.0
  • OS (e.g: cat /etc/os-release): Ubuntu 20.04.4 LTS
  • Kernel (e.g. uname -a): Linux 5.10.112-11.al8.x86_64 ✨ Add NodeMetric API #1 SMP Tue May 24 16:05:50 CST 2022 x86_64 x86_64 x86_64 GNU/Linux

Anything else we need to know:

@j4ckstraw j4ckstraw added the kind/question Support request or question relating to Koordinator label Oct 30, 2023
@j4ckstraw j4ckstraw changed the title [question] [question] 关于batch资源计算方式的疑问 Oct 30, 2023
@saintube
Copy link
Member

@j4ckstraw 感谢你的提问。
关于第1点,当前内存维度支持基于 request 的计算策略,可以用于满足仅 CPU 超卖的场景。
关于第2、3点,属于 batch 资源计算中对 Mid Pod request 的感知不准确,需要进行 bugfix,我们可以在此跟踪修复,感兴趣的话也欢迎你的贡献~

@saintube saintube added area/koord-manager bug Something isn't working kind/bug Create a report to help us improve and removed bug Something isn't working labels Oct 31, 2023
j4ckstraw added a commit to j4ckstraw/koordinator that referenced this issue Nov 23, 2023
fix koordinator-sh#1729

Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

Copy link

stale bot commented Feb 29, 2024

This issue has been automatically closed because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Reopen this PR with /reopen
    Thank you for your contributions.

@stale stale bot closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-manager kind/bug Create a report to help us improve kind/question Support request or question relating to Koordinator lifecycle/stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants