Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] The Coscheduling PreFilter method should not return Error if failed #1860

Closed
eahydra opened this issue Jan 19, 2024 · 0 comments · Fixed by #1861
Closed

[proposal] The Coscheduling PreFilter method should not return Error if failed #1860

eahydra opened this issue Jan 19, 2024 · 0 comments · Fixed by #1861
Labels
area/koord-scheduler kind/proposal Create a report to help us improve

Comments

@eahydra
Copy link
Member

eahydra commented Jan 19, 2024

What is your proposal:

If some Pods with the same PodGroup CRD object are created and scheduling fails, the coscheduling PreFilter returns framework.Error to stop preemption, but this is not the best option. It should return framework.UnschedulableAndUnresolvable.

Why is this needed:

framework.Error is special in the scheduler. It represents an internal service exception. We can determine whether the scheduler is healthy by identifying whether there are Errors, but a plugin that frequently returns Errors will prevent us from identifying exceptions.

Is there a suggested solution, if so, please add it:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-scheduler kind/proposal Create a report to help us improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant