[BUG] make build failed

[j4ckstraw]

What happened:

$ make docker-build-koordlet
docker build   --pull -t "ghcr.io/koordinator-sh/koordlet:main-36ad5766" -f docker/koordlet.dockerfile .
Sending build context to Docker daemon  404.2MB
Step 1/23 : FROM --platform=$TARGETPLATFORM golang:1.18 as builder
failed to parse platform : "" is an invalid component of "": platform specifier component must match "^[A-Za-z0-9_-]+$": invalid argument
make: *** [Makefile:135: docker-build-koordlet] Error 1

What you expected to happen:
Build image successfully

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• App version:
• Kubernetes version (use kubectl version):
• Install details (e.g. helm install args):
• Node environment (for koordlet/runtime-proxy issue):
  • Containerd/Docker version:
  • OS version:
  • Kernal version:
  • Cgroup driver: cgroupfs/systemd
• Others:

[j4ckstraw]

make DOCKER_BUILDER="buildx build" docker-build-koordlet work for me.

[saintube]

make DOCKER_BUILDER="buildx build" docker-build-koordlet work for me.

@j4ckstraw Yes. The multi-arch image building should be used with docker buildx. It seems the Makefile is outdated. Could you please help us update it?

[j4ckstraw]

make DOCKER_BUILDER="buildx build" docker-build-koordlet work for me.

@j4ckstraw Yes. The multi-arch image building should be used with docker buildx. It seems the Makefile is outdated. Could you please help us update it?

build with docker buildx build is very slow than docker build, I'll try to find out it before file a pr.

[j4ckstraw]

make DOCKER_BUILDER="buildx build" docker-build-koordlet work for me.

@j4ckstraw Yes. The multi-arch image building should be used with docker buildx. It seems the Makefile is outdated. Could you please help us update it?

build with docker buildx build is very slow than docker build, I'll try to find out it before file a pr.

This command RUN apt update && apt install -y bash build-essential cmake wget consumes a lot of time, so I changed apt source by
add RUN sed -i 's#deb.debian.org#ftp.cn.debian.org#' /etc/apt/sources.list before it.
it works for me.

also note docker/buildx#379