-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix make docker build xxx #1950
chore: fix make docker build xxx #1950
Conversation
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
softwares installed by apt install is more stable than source code, install them first can make better use of the docker build cache Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
- Coverage 67.52% 67.52% -0.01%
==========================================
Files 420 420
Lines 46957 47021 +64
==========================================
+ Hits 31710 31750 +40
- Misses 12938 12958 +20
- Partials 2309 2313 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4cb304f
to
f992948
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fix #1945
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test