Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix make docker build xxx #1950

Merged

Conversation

j4ckstraw
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix #1945

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
softwares installed by apt install is more stable than source code,
install them first can make better use of the docker build cache

Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
docker/koordlet.dockerfile Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (36ad576) to head (4cb304f).
Report is 14 commits behind head on main.

❗ Current head 4cb304f differs from pull request most recent head f992948. Consider uploading reports for the commit f992948 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
- Coverage   67.52%   67.52%   -0.01%     
==========================================
  Files         420      420              
  Lines       46957    47021      +64     
==========================================
+ Hits        31710    31750      +40     
- Misses      12938    12958      +20     
- Partials     2309     2313       +4     
Flag Coverage Δ
unittests 67.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title Fix make docker build xxx chore: fix make docker build xxx Mar 15, 2024
@saintube
Copy link
Member

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 38b449f into koordinator-sh:main Mar 25, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
@j4ckstraw j4ckstraw deleted the fix-make-docker-build-xxx branch April 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] make build failed
3 participants