Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EnqueueRequestForNode should not only watche update of node's allocatable #2116

Open
songtao98 opened this issue Jun 21, 2024 · 3 comments
Labels
help wanted Extra attention is needed kind/bug Create a report to help us improve

Comments

@songtao98
Copy link
Contributor

What happened:
NodeSLO controller should handle the change about node labels, while now it returns with doing nothing if allocatable not changed.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • App version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Node environment (for koordlet/runtime-proxy issue):
    • Containerd/Docker version:
    • OS version:
    • Kernal version:
    • Cgroup driver: cgroupfs/systemd
  • Others:
@songtao98 songtao98 added the kind/bug Create a report to help us improve label Jun 21, 2024
@songtao98
Copy link
Contributor Author

songtao98 commented Jun 21, 2024

/help

1 similar comment
@songtao98
Copy link
Contributor Author

/help

@koordinator-bot
Copy link

@songtao98:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koordinator-bot koordinator-bot bot added the help wanted Extra attention is needed label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/bug Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

1 participant