Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an issue template and rename feature request to proposal #108

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

hormes
Copy link
Member

@hormes hormes commented Apr 28, 2022

Signed-off-by: Fansong Zeng fanster.z@gmail.com

Ⅰ. Describe what this PR does

add an issue template for user support and rename feature request to proposal, we encourage questions and solutions.

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@hormes
Copy link
Member Author

hormes commented Apr 28, 2022

please review this pr, thanks @jasonliu747

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #108 (37b6515) into main (1df5a76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   44.19%   44.19%           
=======================================
  Files          73       73           
  Lines        5965     5965           
=======================================
  Hits         2636     2636           
  Misses       3036     3036           
  Partials      293      293           
Flag Coverage Δ
unittests 44.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df5a76...37b6515. Read the comment docs.

@hormes
Copy link
Member Author

hormes commented Apr 28, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 73eb08c into koordinator-sh:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants