🌱 add unit test for resmanager #111
Conversation
| } | ||
|
|
||
| spec := nodeSLO.Spec | ||
| switch feature { | ||
| case features.BECPUSuppress, features.BEMemoryEvict: | ||
| // nil value means enabled | ||
| if spec.ResourceUsedThresholdWithBE == nil { | ||
| return false, fmt.Errorf("cannot parse feature config for invalid nodeSLO %v", nodeSLO) | ||
| if spec.ResourceUsedThresholdWithBE == nil || spec.ResourceUsedThresholdWithBE.Enable == nil { |
There was a problem hiding this comment.
these change the default setting of BECPUSuppress & BEMemoryEvict but i think it's acceptable. WDYT @zwzhang0107
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 49.82% 51.35% +1.53%
==========================================
Files 77 77
Lines 7248 7275 +27
==========================================
+ Hits 3611 3736 +125
+ Misses 3309 3207 -102
- Partials 328 332 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add unit test for resmanager.go in koordlet
Ⅱ. Does this pull request fix one issue?
#69
Ⅲ. Describe how to verify it
all checks in action passed
Ⅳ. Special notes for reviews
None