Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu suppress test and revise memory qos #112

Conversation

saintube
Copy link
Member

@saintube saintube commented Apr 29, 2022

Ⅰ. Describe what this PR does

  1. add UTs for feature CPUSuppress
  2. add CRD validations for Memory QoS strategy

Ⅱ. Does this pull request fix one issue?

partially helps #69

Ⅲ. Describe how to verify it

run UTs and see the rise of code coverage

Ⅳ. Special notes for reviews

None

Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the add-cpu-suppress-test-and-revise-memory-qos branch from daec4a4 to d68738b Compare April 29, 2022 10:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #112 (d68738b) into main (dd30303) will increase coverage by 3.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   49.82%   52.91%   +3.08%     
==========================================
  Files          77       77              
  Lines        7248     7250       +2     
==========================================
+ Hits         3611     3836     +225     
+ Misses       3309     3066     -243     
- Partials      328      348      +20     
Flag Coverage Δ
unittests 52.91% <100.00%> (+3.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/system/cgroup_resource.go 0.00% <ø> (ø)
pkg/koordlet/resmanager/cpu_suppress.go 75.00% <100.00%> (+75.00%) ⬆️
pkg/koordlet/resmanager/resmanager.go 5.50% <0.00%> (+2.75%) ⬆️
pkg/koordlet/resmanager/metrics_query.go 56.84% <0.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd30303...d68738b. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Apr 29, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 01a3018 into koordinator-sh:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants