Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add license checker in workflow #117

Merged
merged 1 commit into from
May 5, 2022
Merged

🌱 add license checker in workflow #117

merged 1 commit into from
May 5, 2022

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

This PR will check whether the license headers are included in the source code files. So reviewer won't need to verify it one by one. CI will fail if the license header is missing.

Ⅳ. Special notes for reviews

Blocked by #116

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #117 (5d64391) into main (73eb08c) will increase coverage by 10.15%.
The diff coverage is 72.11%.

❗ Current head 5d64391 differs from pull request most recent head 9845132. Consider uploading reports for the commit 9845132 to get more accurate results

@@             Coverage Diff             @@
##             main     #117       +/-   ##
===========================================
+ Coverage   44.19%   54.34%   +10.15%     
===========================================
  Files          73       77        +4     
  Lines        5965     7277     +1312     
===========================================
+ Hits         2636     3955     +1319     
+ Misses       3036     2972       -64     
- Partials      293      350       +57     
Flag Coverage Δ
unittests 54.34% <72.11%> (+10.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/audit/auditor.go 72.57% <ø> (ø)
pkg/koordlet/audit/config.go 73.33% <ø> (ø)
pkg/koordlet/audit/event_logger.go 69.51% <ø> (ø)
pkg/koordlet/audit/logger.go 72.30% <ø> (ø)
pkg/koordlet/audit/types.go 35.48% <ø> (ø)
pkg/koordlet/config/config.go 69.23% <ø> (ø)
pkg/koordlet/metriccache/config.go 0.00% <ø> (ø)
pkg/koordlet/metriccache/fake_metric_cache.go 0.00% <ø> (ø)
pkg/koordlet/metriccache/metric_cache.go 45.88% <ø> (ø)
pkg/koordlet/metriccache/storage.go 92.40% <ø> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6a707...9845132. Read the comment docs.

@jasonliu747 jasonliu747 marked this pull request as ready for review May 5, 2022 02:06
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@hormes
Copy link
Member

hormes commented May 5, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 94bcf4d into koordinator-sh:main May 5, 2022
@jasonliu747 jasonliu747 deleted the license branch May 5, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants