Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cpu burst strategy #118

Merged
merged 1 commit into from
May 5, 2022
Merged

Support cpu burst strategy #118

merged 1 commit into from
May 5, 2022

Conversation

stormgbs
Copy link
Member

@stormgbs stormgbs commented May 5, 2022

Signed-off-by: bushuang.gbs bushuang.gbs@alibaba-inc.com

Ⅰ. Describe what this PR does

fixes #52

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #118 (172512b) into main (94bcf4d) will decrease coverage by 0.11%.
The diff coverage is 61.81%.

❗ Current head 172512b differs from pull request most recent head 54d6fb9. Consider uploading reports for the commit 54d6fb9 to get more accurate results

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   54.34%   54.23%   -0.12%     
==========================================
  Files          77       77              
  Lines        7277     7331      +54     
==========================================
+ Hits         3955     3976      +21     
- Misses       2972     3000      +28     
- Partials      350      355       +5     
Flag Coverage Δ
unittests 54.23% <61.81%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/nodeslo/nodeslo_controller.go 59.85% <55.55%> (-0.59%) ⬇️
pkg/slo-controller/nodeslo/resource_strategy.go 78.09% <57.50%> (-12.68%) ⬇️
pkg/koordlet/resmanager/types.go 86.16% <100.00%> (+3.15%) ⬆️
...kg/koordlet/resmanager/resource_update_executor.go 64.13% <0.00%> (-11.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94bcf4d...54d6fb9. Read the comment docs.

pkg/util/config.go Outdated Show resolved Hide resolved
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels May 5, 2022
@stormgbs stormgbs requested a review from zwzhang0107 May 5, 2022 05:19
@zwzhang0107
Copy link
Contributor

/lgtm

Signed-off-by: stormgbs <stormgbs@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label May 5, 2022
@stormgbs stormgbs changed the title [feature request] add cpu burst strategy Support cpu burst strategy May 5, 2022
@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 5, 2022
@hormes
Copy link
Member

hormes commented May 5, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 589a433 into koordinator-sh:main May 5, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add cpu burst strategy
5 participants