Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add validation for CRD #133

Merged
merged 1 commit into from
May 13, 2022
Merged

🌱 add validation for CRD #133

merged 1 commit into from
May 13, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

add some range validation for fields.

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes May 11, 2022 14:29
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #133 (245fd5c) into main (c722334) will increase coverage by 0.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   56.38%   57.29%   +0.91%     
==========================================
  Files          78       78              
  Lines        7366     7376      +10     
==========================================
+ Hits         4153     4226      +73     
+ Misses       2840     2767      -73     
- Partials      373      383      +10     
Flag Coverage Δ
unittests 57.29% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/resmanager.go 56.69% <0.00%> (+2.67%) ⬆️
pkg/koordlet/resmanager/memory_evict.go 72.07% <0.00%> (+59.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c722334...245fd5c. Read the comment docs.

Copy link
Contributor

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞 lgtm

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@hormes
Copy link
Member

hormes commented May 13, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, shinytang6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8e647e7 into koordinator-sh:main May 13, 2022
@jasonliu747 jasonliu747 deleted the validation branch May 13, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants