Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add Mid tier api #1375

Conversation

saintube
Copy link
Member

@saintube saintube commented Jun 12, 2023

Ⅰ. Describe what this PR does

Add apis for node recommendation and Mid tier.

Proposed in #1385.

Ⅱ. Does this pull request fix one issue?

Part of #1361.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

/cc @hormes @zwzhang0107 @eahydra

@koordinator-bot koordinator-bot bot requested a review from eahydra June 12, 2023 11:31
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (341fdd8) 64.77% compared to head (9c9a87b) 64.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   64.77%   64.75%   -0.02%     
==========================================
  Files         334      333       -1     
  Lines       34311    34296      -15     
==========================================
- Hits        22226    22210      -16     
+ Misses      10457    10455       -2     
- Partials     1628     1631       +3     
Flag Coverage Δ
unittests 64.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be a proposal for recommendation feature?

@saintube
Copy link
Member Author

will there be a proposal for recommendation feature?

Yes. The proposal will be submitted in another PR.

@saintube saintube force-pushed the apis-add-node-recommendation-and-mid branch 2 times, most recently from bc12ce8 to 7940722 Compare June 13, 2023 10:12
@saintube
Copy link
Member Author

/hold

@saintube saintube force-pushed the apis-add-node-recommendation-and-mid branch from 7940722 to 1a6ec99 Compare June 19, 2023 13:16
@saintube saintube changed the title apis: add node recommendation and Mid tier api apis: add Mid tier api Jun 19, 2023
@koordinator-bot koordinator-bot bot added size/M and removed size/L labels Jun 19, 2023
@saintube
Copy link
Member Author

/unhold

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the apis-add-node-recommendation-and-mid branch from 1a6ec99 to 9c9a87b Compare June 20, 2023 08:38
@hormes
Copy link
Member

hormes commented Jun 20, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 382f7a0 into koordinator-sh:main Jun 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants