-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce PMU multiplexing influence #1489
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
- Coverage 64.12% 64.11% -0.01%
==========================================
Files 342 342
Lines 35204 35210 +6
==========================================
+ Hits 22573 22575 +2
- Misses 10966 10970 +4
Partials 1665 1665
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @songtao98
/lgtm |
Signed-off-by: bowen-intel <bowen.song@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a different computing formula for scalingRatio on kernel Tutorial but this PR's implementation is better for understanding.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, songtao98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
By amplifying the results obtained through 'perf_event_open', reduce the error caused by PMU (Performance Monitoring Unit) time multiplexing when calculating CPI.
Ⅱ. Does this pull request fix one issue?
fixes #1470
Ⅲ. Describe how to verify it
By Grafana?
Ⅳ. Special notes for reviews
V. Checklist
make test