Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: refactor resmanager to qosmanager with plug-in framework #1500

Merged
merged 1 commit into from
Jul 28, 2023
Merged

koordlet: refactor resmanager to qosmanager with plug-in framework #1500

merged 1 commit into from
Jul 28, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jul 27, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#174

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 changed the title koordlet: refactor resmanager to qosmanager koordlet: refactor resmanager to qosmanager with plug-in framework Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 56.00% and project coverage change: -0.28% ⚠️

Comparison is base (091cd40) 64.04% compared to head (8f755ed) 63.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   64.04%   63.77%   -0.28%     
==========================================
  Files         340      346       +6     
  Lines       35056    35123      +67     
==========================================
- Hits        22452    22400      -52     
- Misses      10938    11066     +128     
+ Partials     1666     1657       -9     
Flag Coverage Δ
unittests 63.77% <56.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/koordlet/koordlet.go 8.60% <0.00%> (+0.60%) ⬆️
pkg/koordlet/qosmanager/framework/extension.go 14.70% <ø> (ø)
...g/koordlet/qosmanager/framework/pod_qos_control.go 0.00% <ø> (ø)
pkg/koordlet/qosmanager/helpers/operation.go 0.00% <ø> (ø)
pkg/koordlet/resourceexecutor/executor.go 42.68% <0.00%> (-0.80%) ⬇️
...oordlet/runtimehooks/protocol/container_context.go 32.14% <0.00%> (ø)
...oordlet/statesinformer/impl/states_device_linux.go 36.36% <0.00%> (ø)
...t/qosmanager/plugins/sysreconcile/system_config.go 57.53% <25.00%> (ø)
pkg/koordlet/qosmanager/helpers/property.go 40.00% <40.00%> (ø)
...et/qosmanager/plugins/resctrl/resctrl_reconcile.go 76.22% <41.37%> (ø)
... and 11 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stormgbs stormgbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

pkg/koordlet/qosmanager/framework/context.go Show resolved Hide resolved
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Jul 28, 2023
Copy link
Member

@stormgbs stormgbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 28, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, stormgbs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 281a5e0 into koordinator-sh:main Jul 28, 2023
15 checks passed
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants