Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: PodMigrationJob supports skipping all filters #1505

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Jul 28, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix #1511

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.27% ⚠️

Comparison is base (091cd40) 64.04% compared to head (389c5ee) 63.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   64.04%   63.77%   -0.27%     
==========================================
  Files         340      346       +6     
  Lines       35056    35123      +67     
==========================================
- Hits        22452    22401      -51     
- Misses      10938    11069     +131     
+ Partials     1666     1653      -13     
Flag Coverage Δ
unittests 63.77% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kg/descheduler/controllers/migration/controller.go 65.38% <100.00%> (-0.14%) ⬇️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra
Copy link
Member

eahydra commented Jul 28, 2023

Please add UT for the change.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@ZiMengSheng ZiMengSheng force-pushed the maxUnavailableSensingReplicas branch from 689ffb3 to 389c5ee Compare July 31, 2023 06:42
@koordinator-bot koordinator-bot bot added size/XS and removed size/M labels Jul 31, 2023
@eahydra eahydra changed the title koord-descheduler: make filterMaxAvailablePerWorkload switchable koord-descheduler: PodMigrationJob supports skipping all filters Jul 31, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8f46364 into koordinator-sh:main Jul 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Optimize filter switch of PodMigrations
2 participants