-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: PodMigrationJob supports skipping all filters #1505
koord-descheduler: PodMigrationJob supports skipping all filters #1505
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
- Coverage 64.04% 63.77% -0.27%
==========================================
Files 340 346 +6
Lines 35056 35123 +67
==========================================
- Hits 22452 22401 -51
- Misses 10938 11069 +131
+ Partials 1666 1653 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Please add UT for the change. |
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
689ffb3
to
389c5ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fix #1511
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test