-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: allow quotas that are not bound to pods to become parent nodes #1553
koord-manager: allow quotas that are not bound to pods to become parent nodes #1553
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 65.04% 65.05% +0.01%
==========================================
Files 352 352
Lines 36214 36288 +74
==========================================
+ Hits 23556 23608 +52
- Misses 10919 10938 +19
- Partials 1739 1742 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
055fcf3
to
b20bf7f
Compare
b20bf7f
to
94cf5b1
Compare
94cf5b1
to
bf2a7d5
Compare
/lgtm |
bf2a7d5
to
add7eaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
add7eaa
to
615d6dd
Compare
…nt nodes Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
615d6dd
to
9a48536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm |
@shaloulcy: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nt nodes (koordinator-sh#1553) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
…nt nodes (koordinator-sh#1553) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Relax the limit of IsParent change.
If quota is not bound to pods, it can become parent node.
If quota doesn't have children, it can become child node.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test