-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix test tempdir generation #156
Conversation
On MacOS, the maximum path length of Unix domain socket is 104 characters, see https://unix.stackexchange.com/a/367012/376279 According to the logs, it seems like |
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 56.90% 56.92% +0.02%
==========================================
Files 86 86
Lines 7882 7887 +5
==========================================
+ Hits 4485 4490 +5
Misses 3004 3004
Partials 393 393
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Yes. According to golang/go#21318 , this difference between OS platforms comes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: saintube <saintube@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fix a failure of unit tests on mac os (but not fails CI in GitHub Actions).
Ⅱ. Does this pull request fix one issue?
The issue exists after PR #151 merged.
Ⅲ. Describe how to verify it
make test
gets no errorⅣ. Special notes for reviews
related issues: