-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: add annotation about namespaces that limit quota usage #1566
koord-scheduler: add annotation about namespaces that limit quota usage #1566
Conversation
35726de
to
5c50e24
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
- Coverage 65.29% 65.26% -0.03%
==========================================
Files 369 369
Lines 38117 38188 +71
==========================================
+ Hits 24889 24924 +35
- Misses 11404 11434 +30
- Partials 1824 1830 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
docs/proposals/scheduling/20220722-multi-hierarchy-elastic-quota-management.md
Outdated
Show resolved
Hide resolved
6c8d169
to
48521fb
Compare
docs/proposals/scheduling/20220722-multi-hierarchy-elastic-quota-management.md
Outdated
Show resolved
Hide resolved
48521fb
to
102f602
Compare
docs/proposals/scheduling/20220722-multi-hierarchy-elastic-quota-management.md
Show resolved
Hide resolved
c64f219
to
762af44
Compare
@xulinfei1996 Please add some use cases, why should they be limited to a list of namespaces? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@hormes Koordinator ElasticQuota can support all namspaces by default. On this basis, a namespace list is added to limit, which can be compatible with internal scenarios, such as ACK ElasticQuotaTree. |
@xulinfei1996 Hi, there are some conflicts in the files, please fix them. |
762af44
to
b723f76
Compare
0a5332d
to
e30227c
Compare
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
e30227c
to
b045fc5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ge (koordinator-sh#1566) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
…ge (koordinator-sh#1566) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Add an annotation to expand the bound relationship of ElasticQuota and Pod.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test