Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koordlet: support NodeMetricCollectPolicy #157

Merged
merged 1 commit into from
May 20, 2022
Merged

koordlet: support NodeMetricCollectPolicy #157

merged 1 commit into from
May 20, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented May 19, 2022

NodeMetricCollectPolicy is used to configure the aggregation period and
reporting period. NodeMetric Controller will synchronize the configuration
to NodeMetric from the slo-controller-config configuration.

Signed-off-by: Tao Li joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ref #95

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@eahydra eahydra requested a review from saintube May 19, 2022 11:27
jasonliu747
jasonliu747 reviewed May 19, 2022
View reviewed changes
pkg/util/config.go Outdated Show resolved Hide resolved
saintube
saintube requested changes May 19, 2022
View reviewed changes
pkg/slo-controller/config/constants.go Outdated Show resolved Hide resolved
pkg/koordlet/reporter/reporter.go Outdated Show resolved Hide resolved
pkg/slo-controller/nodemetric/node_event_handler.go Outdated Show resolved Hide resolved
@eahydra eahydra force-pushed the support_node_metric_collect_policy branch 2 times, most recently from 2460555 to 4860f1c Compare May 19, 2022 16:50
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #157 (d83f05f) into main (9f13a7b) will decrease coverage by 0.05%.
The diff coverage is 54.38%.

❗ Current head d83f05f differs from pull request most recent head 0c82cae. Consider uploading reports for the commit 0c82cae to get more accurate results

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   56.92%   56.86%   -0.06%     
==========================================
  Files          86       87       +1     
  Lines        7886     7989     +103     
==========================================
+ Hits         4489     4543      +54     
- Misses       3004     3044      +40     
- Partials      393      402       +9
Flag Coverage Δ
unittests 56.86% <54.38%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/reporter/reporter.go 1.76% <0.00%> (-0.16%) ⬇️
pkg/slo-controller/nodemetric/nodemetric.go 70.00% <25.00%> (-13.34%) ⬇️
pkg/slo-controller/nodemetric/collect_policy.go 59.09% <59.09%> (ø)
...slo-controller/nodemetric/nodemetric_controller.go 60.57% <66.66%> (+7.38%) ⬆️
pkg/slo-controller/config/config.go 86.66% <100.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f13a7b...0c82cae. Read the comment docs.

jasonliu747
jasonliu747 reviewed May 19, 2022
View reviewed changes
pkg/slo-controller/config/config.go Outdated Show resolved Hide resolved
pkg/slo-controller/config/constants.go Outdated Show resolved Hide resolved
pkg/slo-controller/nodemetric/collect_policy.go Outdated Show resolved Hide resolved
pkg/slo-controller/nodemetric/collect_policy.go Outdated Show resolved Hide resolved
@eahydra eahydra force-pushed the support_node_metric_collect_policy branch 2 times, most recently from 697c80f to d83f05f Compare May 20, 2022 06:24
jasonliu747
jasonliu747 reviewed May 20, 2022
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, others PTAL.

pkg/slo-controller/nodemetric/nodemetric_controller.go Show resolved Hide resolved
@eahydra eahydra force-pushed the support_node_metric_collect_policy branch from d83f05f to b55c5d0 Compare May 20, 2022 06:46
@eahydra
koordlet: support NodeMetricCollectPolicy
0c82cae 
NodeMetricCollectPolicy is used to configure the aggregation period and
reporting period. NodeMetric Controller will synchronize the configuration
to NodeMetric from the slo-controller-config configuration.

Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_node_metric_collect_policy branch from b55c5d0 to 0c82cae Compare May 20, 2022 06:53
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 20, 2022
jasonliu747
jasonliu747 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented May 20, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 49dfdbe into koordinator-sh:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonliu747 jasonliu747 jasonliu747 approved these changes

@yihuifeng yihuifeng Awaiting requested review from yihuifeng

@zwzhang0107 zwzhang0107 Awaiting requested review from zwzhang0107

@saintube saintube Awaiting requested review from saintube

Assignees

@saintube saintube

@jasonliu747 jasonliu747

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eahydra @codecov-commenter @saintube @hormes @jasonliu747