Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support collect BE CPU metric #158

Merged
merged 1 commit into from
May 23, 2022
Merged

koordlet: support collect BE CPU metric #158

merged 1 commit into from
May 23, 2022

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented May 19, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

This PR will make metricadvisor be able to collect BE CPU metric.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #158 (f2ae38c) into main (3e70943) will increase coverage by 0.10%.
The diff coverage is 60.71%.

❗ Current head f2ae38c differs from pull request most recent head a7356d6. Consider uploading reports for the commit a7356d6 to get more accurate results

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   57.72%   57.82%   +0.10%     
==========================================
  Files          90       91       +1     
  Lines        8056     8159     +103     
==========================================
+ Hits         4650     4718      +68     
- Misses       3002     3029      +27     
- Partials      404      412       +8     
Flag Coverage Δ
unittests 57.82% <60.71%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 9.69% <0.00%> (-0.03%) ⬇️
pkg/util/container.go 30.62% <0.00%> (+1.28%) ⬆️
pkg/util/node.go 29.62% <0.00%> (-23.71%) ⬇️
pkg/koordlet/metricsadvisor/be_collector.go 68.81% <68.81%> (ø)
pkg/util/stat.go 82.14% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e70943...a7356d6. Read the comment docs.

@saintube
Copy link
Member

/lgtm

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label May 23, 2022
@hormes
Copy link
Member

hormes commented May 23, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1d13d60 into koordinator-sh:main May 23, 2022
@jasonliu747 jasonliu747 deleted the be-collector branch May 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants