Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support running unit test on multiple os #162

Merged
merged 1 commit into from
May 24, 2022
Merged

ci: support running unit test on multiple os #162

merged 1 commit into from
May 24, 2022

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented May 21, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Since majority of programmer are using Mac for development, and deploy Koordinator in a Linux environment. So after #151 , I think it's necessary to run github action on multiple environments like MacOS and Linux.

Ⅱ. Does this pull request fix one issue?

fixes #163

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #162 (d881064) into main (27199b9) will not change coverage.
The diff coverage is n/a.

❗ Current head d881064 differs from pull request most recent head 0fe5a81. Consider uploading reports for the commit 0fe5a81 to get more accurate results

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   57.82%   57.82%           
=======================================
  Files          91       91           
  Lines        8159     8159           
=======================================
  Hits         4718     4718           
  Misses       3029     3029           
  Partials      412      412           
Flag Coverage Δ
unittests 57.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27199b9...0fe5a81. Read the comment docs.

@jasonliu747 jasonliu747 changed the title ci: support multiple os ci: support running unit test on multiple os May 21, 2022
@jasonliu747 jasonliu747 assigned stormgbs and zwzhang0107 and unassigned stormgbs May 23, 2022
@hormes
Copy link
Member

hormes commented May 23, 2022

It might be too slow to run on Mac, can it be made optional?

@jasonliu747
Copy link
Member Author

/hold

@jasonliu747
Copy link
Member Author

/hold cancel

@jasonliu747
Copy link
Member Author

It might be too slow to run on Mac, can it be made optional?

@hormes I've tried almost every possible solution but without success. Let's merge this PR firtst, and I'll open an issue in here.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@hormes
Copy link
Member

hormes commented May 24, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6db62c3 into koordinator-sh:main May 24, 2022
@jasonliu747 jasonliu747 deleted the ci branch May 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[support request] Run GitHub Action on multiple environments
5 participants