Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support cpu evict feature #169

Merged
merged 1 commit into from
May 25, 2022
Merged

koordlet: support cpu evict feature #169

merged 1 commit into from
May 25, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #147

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@jasonliu747
Copy link
Member Author

jasonliu747 commented May 24, 2022

/cc @hormes @saintube @stormgbs

@koordinator-bot koordinator-bot bot requested review from hormes and saintube May 24, 2022 17:02
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #169 (0be4b70) into main (cb90038) will increase coverage by 0.47%.
The diff coverage is 72.98%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   57.82%   58.30%   +0.47%     
==========================================
  Files          91       92       +1     
  Lines        8159     8370     +211     
==========================================
+ Hits         4718     4880     +162     
- Misses       3029     3077      +48     
- Partials      412      413       +1     
Flag Coverage Δ
unittests 58.30% <72.98%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/resmanager.go 56.66% <0.00%> (-1.46%) ⬇️
pkg/koordlet/resmanager/config.go 56.25% <50.00%> (-2.09%) ⬇️
pkg/koordlet/resmanager/cpu_evict.go 74.12% <74.12%> (ø)
pkg/koordlet/resmanager/metrics_query.go 66.32% <100.00%> (+9.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb90038...0be4b70. Read the comment docs.

@koordinator-bot koordinator-bot bot requested a review from stormgbs May 25, 2022 02:41
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_evict.go Outdated Show resolved Hide resolved
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@stormgbs
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented May 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ea8496c into koordinator-sh:main May 25, 2022
@jasonliu747 jasonliu747 deleted the cpu-evict branch May 25, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] evict strategy based cpu usage
5 participants