Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: Add non-preemptible Request in quotaInfo's QuotaCalculateInfo #1755

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Nov 23, 2023

Ⅰ. Describe what this PR does

Add NonPreemptibleRequest in quotaInfo's QuotaCalculateInfo.
With Min and NonPreemptibleRequest, for each quotaInfo, we can calculate the upper limit of the preemptible pod used. If the used of preemptible pod exceeds the upper limit, we will revoke the preemptible pods until preemptible pods used not exceeds the upper limit. It's the supplementary method of preemption in postFilter.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (9f9557e) 66.07% compared to head (7dc6b01) 66.11%.

Files Patch % Lines
pkg/scheduler/plugins/elasticquota/controller.go 51.51% 12 Missing and 4 partials ⚠️
...r/plugins/elasticquota/core/group_quota_manager.go 90.62% 3 Missing ⚠️
.../scheduler/plugins/elasticquota/core/quota_info.go 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   66.07%   66.11%   +0.03%     
==========================================
  Files         388      388              
  Lines       42438    42476      +38     
==========================================
+ Hits        28041    28082      +41     
- Misses      12321    12322       +1     
+ Partials     2076     2072       -4     
Flag Coverage Δ
unittests 66.11% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title koord-scheduler: Add non-preemptible Request in quotaInfo's QuotaCalculateInfo scheduler: Add non-preemptible Request in quotaInfo's QuotaCalculateInfo Nov 23, 2023
@eahydra
Copy link
Member

eahydra commented Nov 23, 2023

/cc @jiasheng55 @tan90github

@koordinator-bot
Copy link

@eahydra: GitHub didn't allow me to request PR reviews from the following users: jiasheng55, tan90github.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jiasheng55 @tan90github

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eahydra
Copy link
Member

eahydra commented Nov 23, 2023

/cc @shaloulcy

@jiasheng55
Copy link

what is the background, what problem does it aim to solve?

@jiasheng55
Copy link

/lgtm

@koordinator-bot
Copy link

@jiasheng55: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ulateInfo

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shaloulcy
Copy link
Contributor

/lgtm

@eahydra
Copy link
Member

eahydra commented Nov 24, 2023

/approve

1 similar comment
@FillZpp
Copy link
Member

FillZpp commented Nov 24, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 661dd71 into koordinator-sh:main Nov 24, 2023
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…nfo (koordinator-sh#1755)

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants