-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: Add non-preemptible Request in quotaInfo's QuotaCalculateInfo #1755
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
+ Coverage 66.07% 66.11% +0.03%
==========================================
Files 388 388
Lines 42438 42476 +38
==========================================
+ Hits 28041 28082 +41
- Misses 12321 12322 +1
+ Partials 2076 2072 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@eahydra: GitHub didn't allow me to request PR reviews from the following users: jiasheng55, tan90github. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @shaloulcy |
what is the background, what problem does it aim to solve? |
5e26852
to
ad28350
Compare
/lgtm |
@jiasheng55: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ulateInfo Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nfo (koordinator-sh#1755) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Add NonPreemptibleRequest in quotaInfo's QuotaCalculateInfo.
With Min and NonPreemptibleRequest, for each quotaInfo, we can calculate the upper limit of the preemptible pod used. If the used of preemptible pod exceeds the upper limit, we will revoke the preemptible pods until preemptible pods used not exceeds the upper limit. It's the supplementary method of preemption in postFilter.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test