Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the runtime-manager design doc #178

Merged
merged 1 commit into from
May 30, 2022

Conversation

honpey
Copy link
Contributor

@honpey honpey commented May 27, 2022

Signed-off-by: honpey honpey@gmail.com

Ⅰ. Describe what this PR does

fixes #144

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@honpey
Copy link
Contributor Author

honpey commented May 27, 2022

/cc @zwzhang0107 @jasonliu747

docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
docs/design-archive/runtime-manager-design-doc.md Outdated Show resolved Hide resolved
@honpey honpey force-pushed the runtime-manager-dev branch 3 times, most recently from 4889e05 to 2f6176f Compare May 27, 2022 11:05
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #178 (0e0189d) into main (6ef657a) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 0e0189d differs from pull request most recent head e6cf167. Consider uploading reports for the commit e6cf167 to get more accurate results

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   58.66%   58.69%   +0.03%     
==========================================
  Files          94       94              
  Lines        8615     8615              
==========================================
+ Hits         5054     5057       +3     
+ Misses       3129     3126       -3     
  Partials      432      432              
Flag Coverage Δ
unittests 58.69% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/slo-controller/nodemetric/node_event_handler.go 0.00% <0.00%> (-37.84%) ⬇️
...slo-controller/nodemetric/nodemetric_controller.go 48.07% <0.00%> (-12.50%) ⬇️
...controller/noderesource/configmap_event_handler.go 35.71% <0.00%> (+35.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef657a...e6cf167. Read the comment docs.

@honpey honpey force-pushed the runtime-manager-dev branch 2 times, most recently from 68dd5d7 to e6cf167 Compare May 30, 2022 02:23
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koordinator-bot
Copy link

@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: ZYecho.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm
others PTAL
/cc @hormes @saintube @zwzhang0107 @stormgbs @ZYecho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: honpey <honpey@gmail.com>
@hormes
Copy link
Member

hormes commented May 30, 2022

/lgtm
/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 219a70a into koordinator-sh:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] runtime-manager manunal
4 participants