-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: add node webhook for resource amplification #1785
Conversation
966e417
to
9aa1b09
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
+ Coverage 66.42% 66.97% +0.54%
==========================================
Files 396 406 +10
Lines 43720 45445 +1725
==========================================
+ Hits 29040 30435 +1395
- Misses 12525 12786 +261
- Partials 2155 2224 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
40d585e
to
73a8c83
Compare
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
0d3ec9c
to
82f9abd
Compare
/milestone v1.4 |
82f9abd
to
b006a87
Compare
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
b006a87
to
9ba0919
Compare
/lgtm |
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
9ba0919
to
d2c28e8
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
…1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
…inator-sh#1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com> fix conflicts in - apis/extension/node_resource_amplification.go - apis/extension/node_resource_amplification_test.go - pkg/slo-controller/noderesource/plugins/batchresource/util_test.go - pkg/webhook/node/plugins/resourceamplification/resource_amplification.go "k8s.io/api/core/v1".Node in argument to extension.GetNodeRawAllocatable "k8s.io/api/core/v1".Node in argument to extension.GetNodeResourceAmplificationRatios - pkg/webhook/node/plugins/resourceamplification/resource_amplification_test.go GetNodeRawAllocatable
feat: webhook: add node webhook for resource amplification (koordinator-sh#1785) See merge request cloud/cloud-native/miks/koordinator!87
ref #1539