webhook: add node webhook for resource amplification #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hormes
force-pushed
the
add_node_webhook
branch
4 times, most recently
from
966e417
to
9aa1b09
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
+ Coverage 66.42% 66.97% +0.54%
==========================================
Files 396 406 +10
Lines 43720 45445 +1725
==========================================
+ Hits 29040 30435 +1395
- Misses 12525 12786 +261
- Partials 2155 2224 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hormes
force-pushed
the
add_node_webhook
branch
2 times, most recently
from
40d585e
to
73a8c83
Compare
zqzten
suggested changes
Dec 21, 2023
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/cpunormalization/node_cpu_normalization.go
Outdated
Show resolved
Hide resolved
eahydra
changed the title
hormes
changed the title
hormes
force-pushed
the
add_node_webhook
branch
2 times, most recently
from
0d3ec9c
to
82f9abd
Compare
|
/milestone v1.4 |
hormes
force-pushed
the
add_node_webhook
branch
from
82f9abd
to
b006a87
Compare
zqzten
suggested changes
Jan 3, 2024
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Outdated
Show resolved
Hide resolved
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
hormes
force-pushed
the
add_node_webhook
branch
from
b006a87
to
9ba0919
Compare
|
/lgtm |
eahydra
requested changes
Jan 6, 2024
pkg/webhook/node/plugins/resourceamplification/resource_amplification.go
Show resolved
Hide resolved
Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
hormes
force-pushed
the
add_node_webhook
branch
from
9ba0919
to
d2c28e8
Compare
|
/lgtm |
zqzten
approved these changes
Jan 9, 2024
eahydra
approved these changes
Jan 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bowen-intel
pushed a commit
to kangclzjc/koordinator
that referenced
this pull request
Jan 16, 2024
…1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com>
yangfeiyu20102011
pushed a commit
to yangfeiyu20102011/koordinator
that referenced
this pull request
Jul 29, 2024
…inator-sh#1785) Signed-off-by: 逐灵 <fansong.cfs@alibaba-inc.com> fix conflicts in - apis/extension/node_resource_amplification.go - apis/extension/node_resource_amplification_test.go - pkg/slo-controller/noderesource/plugins/batchresource/util_test.go - pkg/webhook/node/plugins/resourceamplification/resource_amplification.go "k8s.io/api/core/v1".Node in argument to extension.GetNodeRawAllocatable "k8s.io/api/core/v1".Node in argument to extension.GetNodeResourceAmplificationRatios - pkg/webhook/node/plugins/resourceamplification/resource_amplification_test.go GetNodeRawAllocatable
yangfeiyu20102011
pushed a commit
to yangfeiyu20102011/koordinator
that referenced
this pull request
Jul 29, 2024
feat: webhook: add node webhook for resource amplification (koordinator-sh#1785) See merge request cloud/cloud-native/miks/koordinator!87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1539