-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: Resctrl Qos Enhancement Proposal #1798
proposal: Resctrl Qos Enhancement Proposal #1798
Conversation
Will signoff later~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
+ Coverage 66.42% 67.25% +0.83%
==========================================
Files 396 407 +11
Lines 43739 45644 +1905
==========================================
+ Hits 29053 30698 +1645
- Misses 12525 12730 +205
- Partials 2161 2216 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3c7050c
to
5a61acc
Compare
/lgtm |
Sure, let me create several issues and link them to this proposal |
docs/proposals/koordlet/20231227-koordlet-resctrl-qos-enhance.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20231227-koordlet-resctrl-qos-enhance.md
Outdated
Show resolved
Hide resolved
b952aec
to
4e006d9
Compare
1e0525d
to
6b867b2
Compare
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Ⅰ. Describe what this PR does
Koordinator support LLC and MBA configuration and adjustment by config map based on class level. It uses a goroutine to set/adjust RDT configuration in async mode which may not in real time. As Koordinator already support NRI in 0.3.0 release, we can migrate current function into Koordlet runtimehooks as an runtime hook plugin which could be more real time. Furthermore, we propose bolstering resctrl capabilities by integrating real-time monitoring and pod-level LLC/MBA configuration/adjustment. This richer data landscape will empower Koordinator to make informed decisions regarding the dynamic allocation of LLC, MBA, and potentially even other resources, tailoring them to the specific needs of diverse workloads.
Ⅱ. Does this pull request fix one issue?
fixes #756
Ⅲ. Describe how to verify it
Update resctrl configmap and then check the resctrl group.
Ⅳ. Special notes for reviews
V. Checklist
make test