Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Resctrl Qos Enhancement Proposal #1798

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

kangclzjc
Copy link
Member

@kangclzjc kangclzjc commented Dec 27, 2023

Ⅰ. Describe what this PR does

Koordinator support LLC and MBA configuration and adjustment by config map based on class level. It uses a goroutine to set/adjust RDT configuration in async mode which may not in real time. As Koordinator already support NRI in 0.3.0 release, we can migrate current function into Koordlet runtimehooks as an runtime hook plugin which could be more real time. Furthermore, we propose bolstering resctrl capabilities by integrating real-time monitoring and pod-level LLC/MBA configuration/adjustment. This richer data landscape will empower Koordinator to make informed decisions regarding the dynamic allocation of LLC, MBA, and potentially even other resources, tailoring them to the specific needs of diverse workloads.

Ⅱ. Does this pull request fix one issue?

fixes #756

Ⅲ. Describe how to verify it

Update resctrl configmap and then check the resctrl group.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@kangclzjc
Copy link
Member Author

Will signoff later~

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a404e7f) 66.42% compared to head (6b867b2) 67.25%.
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
+ Coverage   66.42%   67.25%   +0.83%     
==========================================
  Files         396      407      +11     
  Lines       43739    45644    +1905     
==========================================
+ Hits        29053    30698    +1645     
- Misses      12525    12730     +205     
- Partials     2161     2216      +55     
Flag Coverage Δ
unittests 67.25% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kangclzjc kangclzjc force-pushed the resctrl-proposal branch 4 times, most recently from 3c7050c to 5a61acc Compare January 2, 2024 07:51
@zwzhang0107
Copy link
Contributor

/lgtm
next i think it will be better to split into some issues to follow this proposal

@kangclzjc
Copy link
Member Author

/lgtm next i think it will be better to split into some issues to follow this proposal

Sure, let me create several issues and link them to this proposal

@koordinator-bot koordinator-bot bot removed the lgtm label Jan 18, 2024
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Jan 22, 2024
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jan 29, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a056ccb into koordinator-sh:main Jan 30, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] move LLC isolation plugin as runtime hooks plugin
6 participants