koord-manager: refactor gpu device resource plugin #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
+ Coverage 67.08% 67.26% +0.17%
==========================================
Files 407 407
Lines 45702 45650 -52
==========================================
+ Hits 30660 30707 +47
+ Misses 12820 12731 -89
+ Partials 2222 2212 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saintube
force-pushed
the
koord-manager-refactor-gpu-device-resource-plugin
branch
from
ca8c2d8
to
1300ec8
Compare
saintube
force-pushed
the
koord-manager-refactor-gpu-device-resource-plugin
branch
from
1300ec8
to
9b26e92
Compare
saintube
changed the title
saintube
force-pushed
the
koord-manager-refactor-gpu-device-resource-plugin
branch
from
9b26e92
to
fd10089
Compare
eahydra
reviewed
Jan 18, 2024
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/gpudeviceresource/plugin.go
Outdated
Show resolved
Hide resolved
zwzhang0107
reviewed
Jan 18, 2024
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koord-manager-refactor-gpu-device-resource-plugin
branch
from
fd10089
to
2f32371
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koord-manager: refactor GPU resource calculator as a noderesource plugin.
Ⅱ. Does this pull request fix one issue?
Part of #1834.
It standardizes the workflow of the GPU device resource updating, hence allowing us to disable the plugin if needed.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
To keep the consistent behavior with the former version, the GPU device reconciliation logic is just refactored without any improvement in this PR. Some resource updating logic should be revisited, e.g.
In addition, the device resource updating should support the NUMA-level calculation in the future.
V. Checklist
make test