-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: eliminate cache GC is not started #1849
koordlet: eliminate cache GC is not started #1849
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 67.05% 67.02% -0.03%
==========================================
Files 407 407
Lines 45733 45733
==========================================
- Hits 30664 30651 -13
- Misses 12831 12843 +12
- Partials 2238 2239 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Ⅰ. Describe what this PR does
koordlet: eliminate the error "cache GC is not started" when the koordlet starts.
Ⅱ. Does this pull request fix one issue?
related to #1728.
It fixes the cgroups updating failure of the runtime hooks' rule callbacks since they can be invoked just after the states informer's running and before the runtime hook runs.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test