-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: optimize ElasticQuota status/metrics sync flow #1850
scheduler: optimize ElasticQuota status/metrics sync flow #1850
Conversation
8c80a04
to
eb38f5b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
+ Coverage 67.04% 67.06% +0.02%
==========================================
Files 407 407
Lines 45741 45702 -39
==========================================
- Hits 30669 30652 -17
+ Misses 12834 12828 -6
+ Partials 2238 2222 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
@xulinfei1996: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eb38f5b
to
be13681
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r-sh#1850) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…r-sh#1850) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…r-sh#1850) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…r-sh#1850) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
Optimize ElasticQuota status/metrics sync flow, make it more simple and make sure their implementations are consistent.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test