Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: optimize ElasticQuota status/metrics sync flow #1850

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 17, 2024

Ⅰ. Describe what this PR does

Optimize ElasticQuota status/metrics sync flow, make it more simple and make sure their implementations are consistent.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (9ecac4b) 67.04% compared to head (be13681) 67.06%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/elasticquota/controller.go 70.12% 35 Missing and 11 partials ⚠️
...r/plugins/elasticquota/core/group_quota_manager.go 0.00% 7 Missing ⚠️
.../scheduler/plugins/elasticquota/core/quota_info.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   67.04%   67.06%   +0.02%     
==========================================
  Files         407      407              
  Lines       45741    45702      -39     
==========================================
- Hits        30669    30652      -17     
+ Misses      12834    12828       -6     
+ Partials     2238     2222      -16     
Flag Coverage Δ
unittests 67.06% <67.91%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xulinfei1996
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

@xulinfei1996: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the optimize_elasticquota_metrics branch from eb38f5b to be13681 Compare January 17, 2024 12:34
@shaloulcy
Copy link
Contributor

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c20d185 into koordinator-sh:main Jan 18, 2024
21 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants