Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: improve plugin args #1857

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 19, 2024

Ⅰ. Describe what this PR does

Improve plugin args by fixing JSON tags and removing unnecessary pointers

  • Added missing JSON tags to the plugin arguments to ensure proper serialization.
  • Removed pointers from struct fields where direct values are more appropriate, reducing the potential for nil pointer dereferences and simplifying the codebase.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (afbfea0) 67.09% compared to head (dee52a3) 67.09%.
Report is 2 commits behind head on main.

Files Patch % Lines
...cheduler/plugins/coscheduling/plugin_controller.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/elasticquota/plugin.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   67.09%   67.09%   -0.01%     
==========================================
  Files         407      407              
  Lines       45702    45696       -6     
==========================================
- Hits        30664    30659       -5     
+ Misses      12814    12813       -1     
  Partials     2224     2224              
Flag Coverage Δ
unittests 67.09% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Jan 19, 2024

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3d964cf into koordinator-sh:main Jan 19, 2024
20 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants