Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: add node affinity for pod when MultiQuotaTree on #1864

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add node affinity for pod when MultiQuotaTree on

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp January 23, 2024 05:46
@eahydra eahydra changed the title scheduler: add node affinity for pod when MultiQuotaTree on webhook: add node affinity for pod when MultiQuotaTree on Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (da6a05c) 67.23% compared to head (3aa778d) 67.26%.
Report is 4 commits behind head on main.

Files Patch % Lines
.../webhook/pod/mutating/multi_quota_tree_affinity.go 71.73% 19 Missing and 7 partials ⚠️
pkg/webhook/pod/mutating/mutating_handler.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   67.23%   67.26%   +0.02%     
==========================================
  Files         407      408       +1     
  Lines       45644    45740      +96     
==========================================
+ Hits        30687    30765      +78     
- Misses      12741    12759      +18     
  Partials     2216     2216              
Flag Coverage Δ
unittests 67.26% <68.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaloulcy shaloulcy force-pushed the add_webhook_for_quota_tree branch from 5ab360d to b0ecac5 Compare January 23, 2024 05:59
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Jan 23, 2024
@shaloulcy shaloulcy force-pushed the add_webhook_for_quota_tree branch from b0ecac5 to d9b52d9 Compare January 23, 2024 06:02
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@shaloulcy shaloulcy force-pushed the add_webhook_for_quota_tree branch from d9b52d9 to 3aa778d Compare January 23, 2024 06:10
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1158040 into koordinator-sh:main Jan 26, 2024
20 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
…r-sh#1864)

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants