Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix the method of calculating desiredCount in DeviceShare ApplyForAll strategy #1870

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 25, 2024

Ⅰ. Describe what this PR does

  1. Add unit testing for DefaultDeviceHandler of DeviceShare plugin.
  2. Fix the method of calculating desiredCount in DeviceShare ApplyForAll strategy. The ApplyForAll strategy will select devices that match the selector of hint, if no devices can match, will return the error to stop scheduling.

Ⅱ. Does this pull request fix one issue?

fix #1869

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…ApplyForAll strategy

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (07e51fa) 67.23% compared to head (1ad34d9) 67.28%.
Report is 1 commits behind head on main.

Files Patch % Lines
...duler/plugins/deviceshare/devicehandler_default.go 92.59% 1 Missing and 1 partial ⚠️
...scheduler/plugins/deviceshare/devicehandler_gpu.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   67.23%   67.28%   +0.04%     
==========================================
  Files         410      410              
  Lines       45662    45676      +14     
==========================================
+ Hits        30702    30731      +29     
+ Misses      12742    12730      -12     
+ Partials     2218     2215       -3     
Flag Coverage Δ
unittests 67.28% <90.62%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9a76018 into koordinator-sh:main Jan 26, 2024
20 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
…ApplyForAll strategy (koordinator-sh#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
…ApplyForAll strategy (#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
…ApplyForAll strategy (koordinator-sh#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
…ApplyForAll strategy (koordinator-sh#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
…ApplyForAll strategy (#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…ApplyForAll strategy (koordinator-sh#1870)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ApplyForAll devices but failed
3 participants