-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix the method of calculating desiredCount in DeviceShare ApplyForAll strategy #1870
scheduler: fix the method of calculating desiredCount in DeviceShare ApplyForAll strategy #1870
Conversation
…ApplyForAll strategy Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 67.23% 67.28% +0.04%
==========================================
Files 410 410
Lines 45662 45676 +14
==========================================
+ Hits 30702 30731 +29
+ Misses 12742 12730 -12
+ Partials 2218 2215 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ApplyForAll strategy (koordinator-sh#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…ApplyForAll strategy (#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…ApplyForAll strategy (koordinator-sh#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…ApplyForAll strategy (koordinator-sh#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…ApplyForAll strategy (#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…ApplyForAll strategy (koordinator-sh#1870) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
ApplyForAll
strategy will select devices that match the selector of hint, if no devices can match, will return the error to stop scheduling.Ⅱ. Does this pull request fix one issue?
fix #1869
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test