Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: improve node affinity performance for MultiQuotaTree #1872

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

webhook: improve node affinity performance for MultiQuotaTree

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1158040) 67.28% compared to head (6706d68) 67.36%.
Report is 6 commits behind head on main.

Files Patch % Lines
...k/elasticquota/plugin_check_quota_meta_validate.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   67.28%   67.36%   +0.07%     
==========================================
  Files         411      411              
  Lines       45772    45899     +127     
==========================================
+ Hits        30796    30918     +122     
+ Misses      12751    12739      -12     
- Partials     2225     2242      +17     
Flag Coverage Δ
unittests 67.36% <93.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@shaloulcy shaloulcy force-pushed the fix_affinity branch 4 times, most recently from 57cfe30 to 330dd1d Compare January 29, 2024 03:41
… changed

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Feb 2, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 451740f into koordinator-sh:main Feb 2, 2024
20 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
…nator-sh#1872)

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
…nator-sh#1872)

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
…nator-sh#1872)

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…nator-sh#1872)

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants