Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: export mid resource metrics #1874

Merged

Conversation

j4ckstraw
Copy link
Contributor

@j4ckstraw j4ckstraw commented Jan 29, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a056ccb) 67.26% compared to head (cc0b0e5) 67.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/koordlet/statesinformer/impl/states_pods.go 0.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
- Coverage   67.26%   67.22%   -0.04%     
==========================================
  Files         411      411              
  Lines       45848    45866      +18     
==========================================
- Hits        30838    30835       -3     
- Misses      12778    12793      +15     
- Partials     2232     2238       +6     
Flag Coverage Δ
unittests 67.22% <33.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/M and removed size/S labels Jan 30, 2024
@j4ckstraw j4ckstraw marked this pull request as ready for review January 30, 2024 01:43
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
@j4ckstraw
Copy link
Contributor Author

/retest

@saintube saintube changed the title feat: export mid resource metrics koordlet: export mid resource metrics Jan 30, 2024
@saintube
Copy link
Member

/lgtm

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b547abb into koordinator-sh:main Jan 30, 2024
20 checks passed
@j4ckstraw j4ckstraw deleted the export-mid-resource-metric branch January 30, 2024 07:54
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
yangfeiyu20102011 pushed a commit to yangfeiyu20102011/koordinator that referenced this pull request May 29, 2024
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants