Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: decouple CUDA dependency Accelerators feature disabled #1876

Conversation

saintube
Copy link
Member

@saintube saintube commented Jan 29, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…abled

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (22ffeec) 67.27% compared to head (b2ef5c8) 67.24%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/koordlet/util/cpuinfo.go 0.00% 4 Missing and 1 partial ⚠️
pkg/koordlet/metricsadvisor/metrics_advisor.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   67.27%   67.24%   -0.03%     
==========================================
  Files         411      411              
  Lines       45848    45857       +9     
==========================================
- Hits        30842    30838       -4     
- Misses      12774    12787      +13     
  Partials     2232     2232              
Flag Coverage Δ
unittests 67.24% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title [WIP] koordlet: decouple nvml dependency when Accelerators feature-gate dis… [WIP] koordlet: decouple CUDA dependency Accelerators feature disabled Jan 30, 2024
@saintube saintube changed the title [WIP] koordlet: decouple CUDA dependency Accelerators feature disabled koordlet: decouple CUDA dependency Accelerators feature disabled Jan 30, 2024
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 83a18bf into koordinator-sh:main Jan 30, 2024
20 checks passed
saintube added a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
saintube added a commit that referenced this pull request Feb 26, 2024
saintube added a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
saintube added a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
saintube added a commit that referenced this pull request Feb 26, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants