Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add metric prediction framework #1880

Closed
wants to merge 0 commits into from
Closed

proposal: add metric prediction framework #1880

wants to merge 0 commits into from

Conversation

xueche
Copy link

@xueche xueche commented Jan 30, 2024

Ⅰ. Describe what this PR does

add resource recommend proposal

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: Patch coverage is 67.75087% with 466 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (ad36a0b) to head (c4d7644).
Report is 51 commits behind head on main.

❗ Current head c4d7644 differs from pull request most recent head cedff54. Consider uploading reports for the commit cedff54 to get more accurate results

Files Patch % Lines
...koordlet/runtimehooks/hooks/terwayqos/terwayqos.go 40.89% 160 Missing and 12 partials ⚠️
...bhook/cm/plugins/sloconfig/resource_qos_checker.go 68.58% 33 Missing and 16 partials ⚠️
pkg/scheduler/frameworkext/reservation_info.go 56.92% 22 Missing and 6 partials ⚠️
pkg/koordlet/util/perf_group/perf_group_linux.go 62.71% 16 Missing and 6 partials ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 74.07% 13 Missing and 8 partials ⚠️
pkg/scheduler/plugins/reservation/transformer.go 48.38% 11 Missing and 5 partials ⚠️
pkg/koordlet/statesinformer/impl/kubelet_stub.go 63.15% 10 Missing and 4 partials ⚠️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 42.85% 9 Missing and 3 partials ⚠️
pkg/webhook/pod/validating/verify_annotations.go 69.44% 10 Missing and 1 partial ⚠️
...ordlet/qosmanager/plugins/blkio/blkio_reconcile.go 81.81% 9 Missing and 1 partial ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
+ Coverage   67.27%   67.53%   +0.25%     
==========================================
  Files         411      420       +9     
  Lines       45875    47059    +1184     
==========================================
+ Hits        30863    31781     +918     
- Misses      12775    12971     +196     
- Partials     2237     2307      +70     
Flag Coverage Δ
unittests 67.53% <67.75%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107 zwzhang0107 changed the title proposal: resource recommend proposal: add metric prediction framework Jan 31, 2024
@zwzhang0107 zwzhang0107 mentioned this pull request Jan 31, 2024
3 tasks
- "@xueche"
- "@zxustc"
- "@zwzhang0107"
reviewers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add necessary reviewers

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants