scheduler: correct NodeNUMAResource handling with NodeFullPCPUsOnly and preferredCPUBindPolicy #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd preferredCPUBindPolicy Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
fix_nodenumaresource_node_fullcpus_only
branch
from
8544dd0
to
f089122
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
+ Coverage 67.53% 67.54% +0.01%
==========================================
Files 413 413
Lines 46070 46072 +2
==========================================
+ Hits 31114 31120 +6
+ Misses 12706 12702 -4
Partials 2250 2250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 22, 2024
…nd preferredCPUBindPolicy (koordinator-sh#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
…nd preferredCPUBindPolicy (#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…nd preferredCPUBindPolicy (koordinator-sh#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…nd preferredCPUBindPolicy (koordinator-sh#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
…nd preferredCPUBindPolicy (#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…nd preferredCPUBindPolicy (koordinator-sh#1891) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Bug caused when requiredCPUBindPolicy was introduced.
Ⅱ. Does this pull request fix one issue?
fix #1890
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test