Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix misleading query helper #1893

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Feb 5, 2024

Ⅰ. Describe what this PR does

  • koordlet: fix the misleading query helper where someone uses time.Second while others use time.Duration.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (93f2bc2) 67.52% compared to head (577ca16) 67.53%.

Files Patch % Lines
pkg/koordlet/qosmanager/helpers/metrics_query.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   67.52%   67.53%   +0.01%     
==========================================
  Files         413      413              
  Lines       46072    46072              
==========================================
+ Hits        31111    31117       +6     
+ Misses      12705    12702       -3     
+ Partials     2256     2253       -3     
Flag Coverage Δ
unittests 67.53% <84.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit bdaf284 into koordinator-sh:main Feb 5, 2024
20 checks passed
saintube added a commit to saintube/koordinator that referenced this pull request Feb 22, 2024
Signed-off-by: saintube <saintube@foxmail.com>
saintube added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: saintube <saintube@foxmail.com>
saintube added a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
Signed-off-by: saintube <saintube@foxmail.com>
saintube added a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
Signed-off-by: saintube <saintube@foxmail.com>
saintube added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants