Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: forbid use internal protocols #1911

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ls-2018
Copy link
Contributor

@ls-2018 ls-2018 commented Feb 21, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (b634779) to head (fcf43d7).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/webhook/pod/validating/verify_annotations.go 69.44% 10 Missing and 1 partial ⚠️
pkg/webhook/pod/validating/validating_handler.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage   67.53%   67.54%           
=======================================
  Files         413      414    +1     
  Lines       46229    46284   +55     
=======================================
+ Hits        31223    31262   +39     
- Misses      12742    12750    +8     
- Partials     2264     2272    +8     
Flag Coverage Δ
unittests 67.54% <65.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title koord-manager: forbid use internal statements koord-manager: forbid use internal protocols Feb 22, 2024
@eahydra eahydra changed the title koord-manager: forbid use internal protocols webhook: forbid use internal protocols Feb 22, 2024
@ls-2018 ls-2018 requested a review from saintube February 22, 2024 05:51
@koordinator-bot koordinator-bot bot added size/M and removed size/S labels Feb 22, 2024
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Feb 22, 2024
@ls-2018 ls-2018 requested a review from eahydra February 22, 2024 07:51
@ls-2018 ls-2018 force-pushed the forbid branch 7 times, most recently from 11ecaf3 to dbc8ec6 Compare February 22, 2024 09:40
@ls-2018
Copy link
Contributor Author

ls-2018 commented Feb 22, 2024

professional.👍🏻 @eahydra @saintube

@ls-2018 ls-2018 requested a review from eahydra February 22, 2024 11:03
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @saintube Do you have any further comments?

@koordinator-bot koordinator-bot bot added the lgtm label Feb 23, 2024
Signed-off-by: 刘硕 <liushuo@zetyun.com>
@saintube
Copy link
Member

/lgtm

@eahydra
Copy link
Member

eahydra commented Feb 23, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 19de595 into koordinator-sh:main Feb 23, 2024
20 checks passed
eahydra added a commit that referenced this pull request Feb 23, 2024
@ls-2018 ls-2018 deleted the forbid branch February 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants