-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add metrics for kubelet and resource executor #1913
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 67.53% 67.53% -0.01%
==========================================
Files 413 415 +2
Lines 46229 46257 +28
==========================================
+ Hits 31223 31238 +15
- Misses 12742 12750 +8
- Partials 2264 2269 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2c50351
to
6b29237
Compare
/lgtm |
/appprove |
/approve |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
6b29237
to
6cb8824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
…sh#1913) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Ⅰ. Describe what this PR does
#1867
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
curl http://localhost:9316/metrics
Ⅳ. Special notes for reviews
V. Checklist
make test