Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add metrics for kubelet and resource executor #1913

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Feb 22, 2024

Ⅰ. Describe what this PR does

#1867

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

curl http://localhost:9316/metrics

koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="0.001"} 64
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="0.004"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="0.016"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="0.064"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="0.256"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="1.024"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="4.096"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/configz",verb="get",le="+Inf"} 65
koordlet_kubelet_request_duration_seconds_sum{code="200",path="/configz",verb="get"} 0.03827992899999999
koordlet_kubelet_request_duration_seconds_count{code="200",path="/configz",verb="get"} 65
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="0.001"} 0
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="0.004"} 17
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="0.016"} 20
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="0.064"} 20
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="0.256"} 20
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="1.024"} 20
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="4.096"} 20
koordlet_kubelet_request_duration_seconds_bucket{code="200",path="/pods/",verb="get",le="+Inf"} 20
koordlet_kubelet_request_duration_seconds_sum{code="200",path="/pods/",verb="get"} 0.05541508399999999
koordlet_kubelet_request_duration_seconds_count{code="200",path="/pods/",verb="get"} 20

# HELP koordlet_resource_update_duration_milliseconds time duration of resource update such as cgroup files
# TYPE koordlet_resource_update_duration_milliseconds histogram
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="0.01"} 0
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="0.04"} 74
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="0.16"} 145
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="0.64"} 146
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="2.56"} 146
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="10.24"} 146
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="40.96"} 146
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="163.84"} 146
koordlet_resource_update_duration_milliseconds_bucket{status="success",type="cgroup",le="+Inf"} 146
koordlet_resource_update_duration_milliseconds_sum{status="success",type="cgroup"} 7.001778000000003
koordlet_resource_update_duration_milliseconds_count{status="success",type="cgroup"} 146

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 72.34043% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (b634779) to head (6cb8824).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/koordlet/metrics/kubelet.go 0.00% 4 Missing ⚠️
pkg/koordlet/resourceexecutor/executor.go 75.00% 1 Missing and 2 partials ⚠️
pkg/koordlet/metrics/resource_executor.go 0.00% 2 Missing ⚠️
pkg/koordlet/resourceexecutor/resctrl_updater.go 0.00% 2 Missing ⚠️
pkg/koordlet/resourceexecutor/updater.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   67.53%   67.53%   -0.01%     
==========================================
  Files         413      415       +2     
  Lines       46229    46257      +28     
==========================================
+ Hits        31223    31238      +15     
- Misses      12742    12750       +8     
- Partials     2264     2269       +5     
Flag Coverage Δ
unittests 67.53% <72.34%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107 zwzhang0107 force-pushed the add-metrics branch 3 times, most recently from 2c50351 to 6b29237 Compare February 22, 2024 08:31
@saintube
Copy link
Member

/lgtm

@zwzhang0107
Copy link
Contributor Author

/appprove

@zwzhang0107
Copy link
Contributor Author

/approve

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Feb 23, 2024
@zwzhang0107
Copy link
Contributor Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c0374ef into koordinator-sh:main Feb 26, 2024
20 checks passed
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants