Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix initializing built-in quota objects #1917

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Feb 23, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@shaloulcy
Copy link
Contributor

/lgtm

@saintube
Copy link
Member

/lgtm

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (b634779) to head (51091d9).

Files Patch % Lines
...kg/scheduler/plugins/elasticquota/plugin_helper.go 42.85% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   67.53%   67.54%           
=======================================
  Files         413      413           
  Lines       46229    46241   +12     
=======================================
+ Hits        31223    31235   +12     
+ Misses      12742    12736    -6     
- Partials     2264     2270    +6     
Flag Coverage Δ
unittests 67.54% <42.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buptcozy
Copy link
Contributor

/lgtm

@eahydra
Copy link
Member Author

eahydra commented Feb 23, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit adb8b81 into koordinator-sh:main Feb 23, 2024
20 checks passed
saintube pushed a commit to saintube/koordinator that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants