Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add resctrl qos collector(WIP) #1922

Closed
wants to merge 1 commit into from

Conversation

bowen-intel
Copy link
Contributor

Ⅰ. Describe what this PR does

Add resctrl qos collector.

Ⅱ. Does this pull request fix one issue?

fixes #1832

Ⅲ. Describe how to verify it

curl http://localhost:9316/metrics|grep resctrl

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 28.26087% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 67.41%. Comparing base (1158040) to head (02cb14a).
Report is 26 commits behind head on main.

Files Patch % Lines
pkg/koordlet/resourceexecutor/resctrl.go 0.00% 74 Missing ⚠️
pkg/koordlet/metrics/resctrl.go 0.00% 9 Missing ⚠️
pkg/koordlet/metriccache/metric_types.go 0.00% 8 Missing ⚠️
pkg/koordlet/util/system/resctrl.go 80.48% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
+ Coverage   67.28%   67.41%   +0.13%     
==========================================
  Files         411      418       +7     
  Lines       45772    46522     +750     
==========================================
+ Hits        30796    31364     +568     
- Misses      12751    12875     +124     
- Partials     2225     2283      +58     
Flag Coverage Δ
unittests 67.41% <28.26%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bowen-intel <bowen.song@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] QoS class level LLC/MBA metrics collector
1 participant