-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager: add featuregate to remove the restriction of parent quota submit pods #1929
manager: add featuregate to remove the restriction of parent quota submit pods #1929
Conversation
…ubmit pods when disable runtime Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
- Coverage 67.53% 67.51% -0.03%
==========================================
Files 414 416 +2
Lines 46287 46400 +113
==========================================
+ Hits 31260 31326 +66
- Misses 12756 12790 +34
- Partials 2271 2284 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
The webhook part looks fine to me. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bmit pods (koordinator-sh#1929) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
This pr add a featureGate for users to remove the restriction of parent quota submit pods.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test