Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: add featuregate to remove the restriction of parent quota submit pods #1929

Merged

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Feb 29, 2024

Ⅰ. Describe what this PR does

This pr add a featureGate for users to remove the restriction of parent quota submit pods.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…ubmit pods when disable runtime

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (19de595) to head (23eb93d).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   67.53%   67.51%   -0.03%     
==========================================
  Files         414      416       +2     
  Lines       46287    46400     +113     
==========================================
+ Hits        31260    31326      +66     
- Misses      12756    12790      +34     
- Partials     2271     2284      +13     
Flag Coverage Δ
unittests 67.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title manager: add featuregate to remove the restrinction of parent quota submit pods when disable runtime manager: add featuregate to remove the restriction of parent quota submit pods when disable runtime Feb 29, 2024
@xulinfei1996 xulinfei1996 changed the title manager: add featuregate to remove the restriction of parent quota submit pods when disable runtime manager: add featuregate to remove the restriction of parent quota submit pods Mar 6, 2024
@saintube saintube requested a review from shaloulcy March 7, 2024 02:13
@FillZpp
Copy link
Member

FillZpp commented Mar 12, 2024

/lgtm

@hormes
Copy link
Member

hormes commented Mar 12, 2024

The webhook part looks fine to me.
The calculation process of the runtime needs to deduct the usage of the parent node, and issues will be recorded for tracking.
/lgtm

@hormes
Copy link
Member

hormes commented Mar 12, 2024

#1946

@hormes
Copy link
Member

hormes commented Mar 12, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3bf7ba8 into koordinator-sh:main Mar 12, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…bmit pods (koordinator-sh#1929)

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants