Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: resolve the wrong use of gangmod in gang init phase #1934

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

PeterChg
Copy link
Contributor

@PeterChg PeterChg commented Mar 4, 2024

Ⅰ. Describe what this PR does

The use of pod and podgroup was confused during the gang init phase, result failed to update the GangMatchPolicy configuration

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from buptcozy and eahydra March 4, 2024 08:56
Signed-off-by: PeterChang <changyi@xiaomi.com>
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (3390433) to head (a0b58ed).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   67.45%   67.44%   -0.01%     
==========================================
  Files         420      420              
  Lines       46885    46885              
==========================================
- Hits        31626    31623       -3     
+ Misses      12962    12959       -3     
- Partials     2297     2303       +6     
Flag Coverage Δ
unittests 67.44% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra
Copy link
Member

eahydra commented Mar 4, 2024

/lgtm
/cc @xulinfei1996 please take a look.

@xulinfei1996
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Mar 4, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c590941 into koordinator-sh:main Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants