Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add Recommendation crd #1937

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Mar 4, 2024

Ⅰ. Describe what this PR does

define the recommendation crd for resource prediction, see #1875 for full story.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

apiVersion: analysis.koordinator.sh/v1alpha1
kind: Recommendation
metadata:
  namespace: default
  name: recommendation-sample
spec:
  target:
    type: workload
    workload:
      apiVersion: apps/v1
      kind: Deployment
      name: nginx-sample-deployment
status:
  podStatus:
    containerStatuses:
    - containerName: nginx
      resources:
        cpu: 1200m
        memory: 1280Mi
  updateTime: "2024-03-05T08:00:00Z"

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (07e51fa) to head (71a41b2).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   67.23%   67.47%   +0.24%     
==========================================
  Files         410      420      +10     
  Lines       45662    46858    +1196     
==========================================
+ Hits        30702    31619     +917     
- Misses      12742    12939     +197     
- Partials     2218     2300      +82     
Flag Coverage Δ
unittests 67.47% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Mar 5, 2024

/lgtm

@songzh215 please take a look this API.

@koordinator-bot koordinator-bot bot removed the lgtm label Mar 6, 2024
Co-authored-by: Zach Zhu <zzqshu@126.com>
Signed-off-by: zwzhang <zzw261520@alibaba-inc.com>
@zxustc
Copy link

zxustc commented Mar 20, 2024

/lgtm

@koordinator-bot
Copy link

@zxustc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hormes
Copy link
Member

hormes commented Mar 20, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Mar 20, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0448219 into koordinator-sh:main Mar 20, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Signed-off-by: zwzhang <zzw261520@alibaba-inc.com>
Co-authored-by: Zach Zhu <zzqshu@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants